Adding and loading options from config #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not exactly sure if it's better to have the validation rules as configs. If an application have different business rules of how a valid user should look a like, then it's a better idea to have a class to do it. Using the config files to do this seems like a bad idea to me :( |
|
Although the validation in config, to save the confirmation But I didn't get why the |
| composer.lock | ||
| .DS_Store |
There was a problem hiding this comment.
This should not be included. It should be part of your global system ignore file, not a project ignore file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd just added the username_type and validation rules into config file to avoid the needs of extend or overwrite the Zizaco classes. This can turn easier to setup and modify rules while using confide.
Thanks for do it, Confide is a great package.
Regards